Skip to content

feat: populate cluster config from client.authentication.k8s.io/exec … #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2025
Merged

feat: populate cluster config from client.authentication.k8s.io/exec … #2399

merged 2 commits into from
Aug 20, 2025

Conversation

ma-ts
Copy link
Contributor

@ma-ts ma-ts commented May 27, 2025 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

populate ExecCredentialSpec.Cluster.config from the client.authentication.k8s.io/exec extension

Which issue(s) this PR fixes:

Fixes #2395

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Adds cluster config information to the exec credential provider if the client.authentication.k8s.io/exec extension is provided.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Recreating PR since #2396 has CLA issues. Credits go to @wkloucek

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 27, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @ma-ts!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested review from fabianvf and yliaog May 27, 2025 18:08
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 27, 2025
@ma-ts
Copy link
Contributor Author

ma-ts commented May 31, 2025

@fabianfv @yliaog Any comments about this PR? Would be nice if we can release this, so that clusters using these extensions can be managed with this library.

Also fixes some big issues on the Azure CLI managing these clusters from Azure.

@roycaihw
Copy link
Member

roycaihw commented Jun 4, 2025

/assign @yliaog

@yliaog
Copy link
Contributor

yliaog commented Jun 4, 2025

could you please take a look at the test failure?

@wkloucek wkloucek mentioned this pull request Jul 14, 2025
Closed
@yliaog
Copy link
Contributor

yliaog commented Aug 19, 2025

/close

will reopen to trigger CI

@k8s-ci-robot
Copy link
Contributor

@yliaog: Closed this PR.

In response to this:

/close

will reopen to trigger CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yliaog
Copy link
Contributor

yliaog commented Aug 19, 2025

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Aug 19, 2025
@k8s-ci-robot
Copy link
Contributor

@yliaog: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yliaog
Copy link
Contributor

yliaog commented Aug 20, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ma-ts, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0c56ef1 into kubernetes-client:master Aug 20, 2025
13 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianvf fabianvf Awaiting requested review from fabianvf

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@yliaog yliaog

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExecCredentialSpec.Cluster. config is missing
4 participants
@ma-ts @k8s-ci-robot @roycaihw @yliaog